Commit graph

488 commits

Author SHA1 Message Date
Noah May 3ecb47ff2c fix(options3): panic when not matching to avoid false positives
Closes #1503
2023-05-09 15:13:18 -05:00
Aaron Wang d3fea5f15a
Merge branch 'main' into patch-2 2023-05-01 19:10:56 -04:00
PiqqiDesigns c4627e7112 chore: clarified cow owned_no_mutation comments 2023-04-27 15:49:40 -07:00
lionel-rowe 836134202e
feat(options2): better tests for layered_option
The existing test can be solved with the following:

```rs
        while let Some(integer) = optional_integers.pop() {
            assert_eq!(integer.unwrap(), range);
```

Similarly with `expect(...)`, `unwrap_or(0)`, `unwrap_or_default()`, etc. However, none of these solutions use the learning point of stacking `Option<T>`s.

The updated test can _only_ be solved by stacking `Option<T>`s:

```rs
        while let Some(Some(integer)) = optional_integers.pop() {
            assert_eq!(integer, cursor);
```

With the updated test, using `unwrap` or `expect` will panic when it hits the `None` value, and using `unwrap_or` or `unwrap_or_default` will cause the final `assert_eq!(cursor, 0)`  to panic.
2023-04-21 06:05:25 +01:00
Alan Gerber 319a8253ba fix(move_semantics2): fix line number comment
Commit fef8314 added three lines of comments, which left the line
numbers expected to stay unchanged mentioned on line 2 out of date.
2023-04-20 12:15:31 -04:00
Your Name 352267871c fix: Added some extra tests to validate iterators5 solution
closes: #1387
2023-04-15 17:34:52 +01:00
bean5 15ae83f868 docs: Replace apostrophe (for consistency with other README files) 2023-04-13 20:32:18 -06:00
Aaron Wang 8ed2cf7ef5
Update move_semantics2.rs 2023-04-10 22:36:21 -04:00
Aaron Wang c74e0bfd18
docs: update line numbers in move_semantics2 2023-04-07 01:56:20 -04:00
liv 087e076ec0
Merge pull request #1384 from stornquist/patch-1
fix(move_semantics2): add expected output comment
2023-04-05 13:10:57 +00:00
liv ab6aa23cec
Merge pull request #1391 from ktheory/ktheory/iter5
docs: clarify instructions on iterators5.rs
2023-04-05 13:06:43 +00:00
liv 5fd3dfe01b
Merge pull request #1452 from guoard/markdown-linter
feat(docs): add markdown linter for exercises README.md files
2023-04-05 13:06:17 +00:00
poneciak 102d7f3d0e changed comments in tests
also fixed small logical issue in `Rectangle::new()` where u could create rectangle with width or height equals 0
2023-04-05 13:24:14 +02:00
poneciak c4974ac782 added required changes
- fixed grammar in hint and added more specific link
- added comments in test functions
- changed introduction paragraph
2023-04-05 13:09:13 +02:00
poneciak 27b7579566 created task 2023-04-05 08:18:51 +02:00
Alexandre ESSE 22bb662d3e fix(exercises): remove trailing spaces 2023-03-31 11:58:15 +02:00
Ali Afsharzadeh 382e16eb7e feat(docs): add markdown linter for exercises README.md files 2023-03-30 19:53:22 +03:30
Ali Afsharzadeh 1db646474e
docs(error_handling): resolve markdown linter warnings 2023-03-29 21:13:27 +03:30
liv 92f09dbe81
Merge pull request #1445 from guoard/patch-1
docs(variables): wrap mut keyword with backtick
2023-03-28 10:26:32 +00:00
liv e0e0b3f387
Merge pull request #1432 from ryanwhitehouse/main
docs:clarify instructions on hashmaps2.rs
2023-03-28 10:25:31 +00:00
Ali Afsharzadeh 592694036f
docs(variables): wrap mut keyword with backtick 2023-03-28 09:58:59 +03:30
liv 2012641610
Merge pull request #1428 from javihernant/changeLtReadme
change order of references in README.md
2023-03-26 13:23:02 +00:00
liv 864e741dd8 reword hashmaps2 a bit more 2023-03-26 15:21:21 +02:00
liv 6d4a87227d
Merge pull request #1437 from navicore/errors2-comment-error
correct comments in errors2.rs
2023-03-26 12:49:59 +00:00
Tom Kunc d5449c992e
feat(lifetimekata): Add info about Lifetimekata project 2023-03-25 20:00:28 +11:00
Ed Sweeney 4160b06c6c correct comments in errors2.rs 2023-03-24 21:52:58 -07:00
Ryan Whitehouse 5687676014 docs:clarify instructions on hashmaps2.rs 2023-03-20 15:19:36 +01:00
hxztnxt 5d91c86cf2 change order of references in README.md 2023-03-16 00:56:15 +01:00
Adam Brewer 7bab78c66d Rename iteration var names in vec2.rs for clarity
Resolves #1417
2023-03-10 14:13:06 -05:00
liv 36e66b545e
Merge pull request #1396 from 0lhi/main
fix(macros4.rs): Add rustfmt::skip to prevent auto-fix.
2023-02-26 13:10:24 +01:00
Chad Dougherty 8c88f769b6
rustfmt
rustfmt converts "main ()" -> "main()"
2023-02-24 08:51:03 -05:00
0lhi de24536187
macros4.rs: Add rustfmt::skip to prevent auto-fix.
The `macros4.rs` challenge can automatically be solved by rustfmt without the user noticing.

Adding `#[rustfmt::skip]` above the `macro_rules!` line fixes this issue.
2023-02-24 01:43:23 +01:00
Aaron Suggs 1ac66f372b docs: clarify instructions on iterators5.rs
I changed the sentence that referenced the imperative implementation in iterators5.rs.

That implementation was already removed and replaced with `todo!()`
2023-02-21 09:45:59 -05:00
Cyril MARPAUD 045d86aa42 refactor(arc1): improve readability by avoiding implicit dereference 2023-02-18 21:38:43 +01:00
Sebastian Törnquist fef8314d3d
fix(move_semantics2): add expected output comment
You can easily get this to compile with `vec0` being `[]` and `vec1` being `[22, 44, 66, 88]`
2023-02-18 18:43:34 +01:00
Gleb Shevchenko 238a496af5 fix: unify undisclosed type notation in errors5.rs 2023-02-18 14:09:04 +01:00
Daan Wynen bbdc5c6039 refactor(cow1): replace main with tests
Following the discussion in #1195 this is the best I could come up with.
The issue for me (and apparently a few other learners) was that the code
needed to complete the exercise was not _missing_, but was rather there
but wrong.

In the end, what made the difference between this exercise and others
(for me) was that in this exercise I was supposed to learn what to
*expect* of an output. So I think it makes sense here to let the learner
modify the tests and not the code itself.

Fixes #1195

Signed-off-by: Daan Wynen <black.puppydog@gmx.de>

# Conflicts:
#	info.toml
2023-02-14 20:37:33 +01:00
magnusrodseth 48ce9d2fd8 docs: add link to docs about iter_mut and map 2023-02-12 18:26:13 +01:00
liv f123cb2777
Merge pull request #1228 from grzegorz-zur/patch-1
Removed unnecessary use statement
2023-02-12 16:54:43 +01:00
liv 7be4fd891d
Merge pull request #1305 from platformer/issue1298
fix(threads1): make program panic if threads are not joined
2023-02-12 16:50:03 +01:00
liv b3de1b77bf
Merge pull request #1318 from kawaiiPlat/q2-minor-grammar
minor grammar tweak for quiz 2
2023-02-12 15:51:42 +01:00
liv 957522a492 feat(intro1): add note on rust-analyzer usage 2023-02-12 15:47:58 +01:00
Kevin Wan 4771a7b9e7
chore: fix prompt error
Missed a blank line, which causes the prompt incorrect like below:

```rust
You can keep working on this exercise,
or jump into the next one by removing the `I AM NOT DONE` comment:

 6 |  // Make this code compile by using the proper Rc primitives to express that the sun has multiple owners.
 7 |  
 8 |  // I AM NOT DONE
 9 |  use std::rc::Rc;
```
2023-01-23 12:16:51 +08:00
Jarrod Sanders 57834e9f8c
Minor Grammar 2023-01-03 09:22:52 -05:00
seporterfield 9860976af9
added existing chapter for clippy to mapping
It's real! https://doc.rust-lang.org/book/appendix-04-useful-development-tools.html
2023-01-01 02:34:58 +01:00
seporterfield b2b6e6900f
reformatted exercise->chapter mapping
Added and removed rows according to changes to exercise order and grouping.
2023-01-01 02:29:45 +01:00
seporterfield 66eaaf7b6e
fixed formatting 2023-01-01 02:17:53 +01:00
seporterfield 3fad2a9c83
gave smart_pointers its own README.md 2023-01-01 02:17:23 +01:00
seporterfield 8405a61b07
moved iterator exercises 2023-01-01 02:02:49 +01:00
seporterfield e3e298cfa2
moved iterator exercises 2023-01-01 02:02:15 +01:00
seporterfield 0f02a9b9af
moved iterator exercises 2023-01-01 02:00:36 +01:00
seporterfield 5b0d587c22
moved iterator exercises 2023-01-01 01:59:35 +01:00
seporterfield e9dc52c2d3
moved iterator exercises 2023-01-01 01:58:57 +01:00
seporterfield a0c5a892d3
refactoring standard_library_types as iterators 2023-01-01 01:58:04 +01:00
seporterfield a8fd315e09
moved rc to smart_pointers 2023-01-01 01:52:47 +01:00
seporterfield e8c4aab643
moved cow to smart_pointers 2023-01-01 01:52:05 +01:00
seporterfield c3bab88fda
moved box to smart_pointers 2023-01-01 01:51:27 +01:00
seporterfield 05592acf40
move arc to smart_pointers 2023-01-01 01:44:47 +01:00
HerschelW 2f821aa30d chore: update enums3.rs addressing extra parentheses usage with tuples 2022-12-30 08:14:13 -06:00
platformer 7e4ce38681 fix(threads1): make program panic if threads are not joined
closes #1298
2022-12-26 02:25:43 -06:00
liv 40b1b07915
fix(enums3): add extra tuple comment 2022-12-23 16:47:48 +01:00
liv 4ede64b729
Merge pull request #1279 from tkburis/main
Minor changes
2022-12-23 16:44:02 +01:00
liv 4521aed23b
Merge pull request #1293 from tysonliddell/fix_self_parameter
fix: Remove superfluous &self indirection
2022-12-23 16:22:51 +01:00
William Webb e519b5079e
fix(hashmaps3): fix typo in todo hint 2022-12-20 21:17:32 -06:00
Tyson Liddell 71873e676f fix: Remove superfluous &self indirection 2022-12-09 20:49:10 +00:00
TK Buristrakul db53dbc126 chore: tidied up unmatched backticks 2022-11-24 19:41:25 +00:00
TK Buristrakul a315f2fefb chore: added more descriptive TODOs 2022-11-24 19:39:54 +00:00
TK Buristrakul be0b7e084e chore: minor change in comment 2022-11-24 19:20:59 +00:00
mfurak 152193b459 style: format errors6 with rustfmt 2022-11-06 20:42:17 +01:00
mfurak d01ce8304e style: format errors5 with rustfmt 2022-11-06 20:32:43 +01:00
liv 7380e43f28
Merge pull request #1246 from tfpk/patch-1
feat(macros-readme): Add link to MacroKata
2022-10-26 10:49:39 +02:00
Tom Kunc da995b24eb
feat(macros-readme): Add link to MacroKata 2022-10-24 13:57:44 +11:00
Arkid 623161e50d
fix: Revert deref change
Revert the addition of a deref in PR #1192 by me, which should not be there.

Apologies for the inconvenience caused.
2022-10-21 02:45:31 +02:00
liv 49a101b189
Merge pull request #1192 from aaarkid/patch-1
fix: Add a deref in the test code
2022-10-18 11:39:35 +02:00
Matthew Van Schellebeeck ccd73c0a81 style: explicitly use Arc::clone 2022-10-17 22:25:28 -05:00
bhbuehler c157c53983 docs(options1): fix and clarify 24 hour time instruction 2022-10-11 12:05:37 -05:00
Grzegorz Żur da6178bdc6
Removed unnecessary use statement 2022-10-11 10:43:32 +02:00
Duchoud Nicolas 76392d81fa
Added spaces around * 2022-10-04 11:43:23 +02:00
Duchoud Nicolas 4749768734
additional test for fees 2022-10-04 11:36:18 +02:00
Tiago De Gaspari 68fe97bbc2
fix(quiz2): fix comment regarding hints
Change the comment on quiz2.rs, since there are no hints.
2022-09-12 10:53:59 -03:00
Arkid 34ed235885
fix: Add a deref in the test code
It's virtually impossible to write a the `num_sq` function to take the Box since it doesn't implement `MulAssign`.
2022-09-09 02:40:22 +02:00
liv 199150fda2
Merge pull request #1171 from memark/patch-1
Add quotes for readability of output
2022-09-06 12:16:54 +02:00
liv 1d5700e58a
fix(quiz1): add fourth assert 2022-09-06 12:10:53 +02:00
liv 96552e07c2
fix(quiz1): correct explanation once again 2022-09-06 12:09:43 +02:00
Magnus Markling 291da61fda
Add quotes 2022-08-28 15:12:15 +02:00
Magnus Markling 94bdb708fe
Add quotes 2022-08-28 15:10:29 +02:00
Kody Low d6e26bb350 2nd assert is for greater than or equal to, not "more than" like it says in the instructions 2022-08-24 08:33:17 -07:00
magnusrodseth 99ea2cbba7 chore: make options2 not compile deliberately 2022-08-17 16:53:41 +02:00
magnusrodseth 52a29aa84b test: Convert main function to working tests 2022-08-17 12:50:34 +02:00
vostok92 4455c22b9a
Update options1.rs
Fix assertions
2022-08-17 13:51:17 +09:00
liv 1c3b003c7c
Merge branch 'main' into rc-exercise 2022-08-16 09:37:34 +02:00
liv 25ab52b8e7
Merge pull request #1103 from exdx/feat/cow
feat: add cow1.rs exercise
2022-08-16 09:35:53 +02:00
Nico Vromans e8122daa87
Update options1.rs
Added extra test for before 10PM and updated the test for at 10PM (when it's 10PM there should already not be any ice cream left, as per the description). Also fixed the `raw_value` test, as it is later than 10PM, so there should be no more ice cream left.
2022-08-15 10:05:50 +02:00
Markus Boehme 3c84cc1702 fix(options1): remove unused code
Since rewriting the exercise in commit 06e4fd3765 the print_number
function goes unused. Remove it.
2022-08-11 22:54:08 +02:00
liv 26b347a8bd
Merge pull request #1131 from johnmendel/main
fix(traits5): make exercise prefer trait-based solution
2022-08-11 12:30:12 +02:00
liv a7ca40d8a3
Merge pull request #1132 from brianfakhoury/patch-1
Fix minor spelling
2022-08-11 12:29:16 +02:00
Mouwrice ef70ad907f fix(macros-readme): update the book link to the more recent version of the book 2022-08-09 20:27:27 +02:00
Brian Fakhoury f25f77e915
Fix minor spelling 2022-08-08 15:39:35 -04:00
John Mendelewski III a0a06232ce fix(traits5): make exercise prefer trait-based solution
closes #1088
2022-08-07 14:51:16 -04:00
liv affc815447
Merge pull request #1112 from tvkn/feat/options1/update-expected-result
feat(options1): update expected result
2022-08-03 17:34:43 +02:00