added required changes
- fixed grammar in hint and added more specific link - added comments in test functions - changed introduction paragraph
This commit is contained in:
parent
27b7579566
commit
c4974ac782
|
@ -1,6 +1,5 @@
|
||||||
// tests4.rs
|
// tests4.rs
|
||||||
// Correct the tests to
|
// Make sure that we're testing for the correct conditions!
|
||||||
// Do not change Rectangle::new body
|
|
||||||
// Execute `rustlings hint tests4` or use the `hint` watch subcommand for a hint.
|
// Execute `rustlings hint tests4` or use the `hint` watch subcommand for a hint.
|
||||||
|
|
||||||
// I AM NOT DONE
|
// I AM NOT DONE
|
||||||
|
@ -11,6 +10,7 @@ struct Rectangle {
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Rectangle {
|
impl Rectangle {
|
||||||
|
// Only change the test functions themselves
|
||||||
pub fn new(width: i32, height: i32) -> Self {
|
pub fn new(width: i32, height: i32) -> Self {
|
||||||
if width < 0 || height < 0 {
|
if width < 0 || height < 0 {
|
||||||
panic!("Rectangle width and height cannot be negative!")
|
panic!("Rectangle width and height cannot be negative!")
|
||||||
|
@ -25,16 +25,21 @@ mod tests {
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn correct_width_and_height() {
|
fn correct_width_and_height() {
|
||||||
let _rect = Rectangle::new(10, 10);
|
// This test should check if the rectangle is the size that we pass into its constructor
|
||||||
|
let rect = Rectangle::new(10, 20);
|
||||||
|
assert_eq!(???, 10); // check width
|
||||||
|
assert_eq!(???, 20); // check height
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn negative_width() {
|
fn negative_width() {
|
||||||
|
// This test should check if thread panics when we try to create rectangle with negative width
|
||||||
let _rect = Rectangle::new(-10, 10);
|
let _rect = Rectangle::new(-10, 10);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn negative_height() {
|
fn negative_height() {
|
||||||
|
// This test should check if thread panics when we try to create rectangle with negative height
|
||||||
let _rect = Rectangle::new(10, -10);
|
let _rect = Rectangle::new(10, -10);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -813,8 +813,9 @@ path = "exercises/tests/tests4.rs"
|
||||||
mode = "test"
|
mode = "test"
|
||||||
hint = """
|
hint = """
|
||||||
We expect method `Rectangle::new()` to panic for negative values.
|
We expect method `Rectangle::new()` to panic for negative values.
|
||||||
To handle that you need to add special attribute to test function.
|
To handle that you need to add a special attribute to the test function.
|
||||||
You can refer to the docs: https://doc.rust-lang.org/stable/book/ch11-01-writing-tests.html"""
|
You can refer to the docs:
|
||||||
|
https://doc.rust-lang.org/stable/book/ch11-01-writing-tests.html#checking-for-panics-with-should_panic"""
|
||||||
|
|
||||||
|
|
||||||
# STANDARD LIBRARY TYPES
|
# STANDARD LIBRARY TYPES
|
||||||
|
|
Loading…
Reference in a new issue